[Freeciv-Dev] Re: (PR#7385) overview isn't updated

["Raimar Falke" <i-freeciv-lists@xxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7385 >

On Mon, Feb 09, 2004 at 10:20:14PM -0800, Jason Dorje Short wrote:
> 
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=7385 >
> 
> Raimar Falke wrote:
> 
> > If you suggest that dirty_overviewcanvas() is gui specific and that
> > flush_mapcanvas() stays this way I disagree. Unification is the big
> > thing we want to have.
> 
> Then you need the equivalent of gtk_window_invalidate_rect to be 
> implemented for each GUI.  This functionality is just too good to be 
> ignored.

Lets see. My plan:
 - dirty code in common
 - gui_canvas_copy in gui-*/

Your plan:
 - dirty code in the clients
 - gtk2 uses gtk_window_invalidate_rect
 - all other clients reimplement gtk_window_invalidate_rect

At least from the code size, maintainability and homogeneous my plan
is better. If however you can show that gtk_window_invalidate_rect is
faster/better by some way I can be convinced otherwise.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "From what I am reading Win98 and NT5.0 will be getting rid of all that
  crap anyway. Seems that Microsoft has invented something called TCP/IP and
  another really revolutionary concept called DNS that eliminates the
  netbios crap too. All that arping from browsers is going to go away.
  I also hear rumors that they are on the verge of breakthrough discoveries
  called NFS, and LPD too. Given enough time and money, they might
  eventually invent Unix."
    -- George Bonser in linux-kernel