[Freeciv-Dev] Re: (PR#7385) overview isn't updated

["Jason Dorje Short" <jdorje@xxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7385 >

Raimar Falke wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=7385 >
> 
> On Sat, Feb 07, 2004 at 10:04:46AM -0800, Jason Dorje Short wrote:
> 
>><URL: http://rt.freeciv.org/Ticket/Display.html?id=7385 >
>>
>>Raimar Falke wrote:
>>
>>><URL: http://rt.freeciv.org/Ticket/Display.html?id=7385 >
>>>
>>>On Fri, Feb 06, 2004 at 12:57:58PM -0800, Jason Dorje Short wrote:
>>>
>>>
>>>><URL: http://rt.freeciv.org/Ticket/Display.html?id=7385 >
>>>>
>>>>The map overview isn't always properly updated.
>>>>
>>>>For instance when the game is over the map is revealed, but the overview 
>>>>isn't updated.  This is new behavior; no doubt a result of the recent 
>>>>overview unification.
>>>>
>>>>Produced with gui-gtk-2.0 but probably common to all clients...
>>>
>>>
>>>Can you provide a savegame?
>>
>>- Start game.
>>- Disband all units.
>>- Look at overview.
> 
> The problem is much worse. The overview isn't updated at all (except
> for expose and recentering). A clear sign that I rushed the patch too
> much and so it got too less testing.
> 
> The fix is to draw (copy to screen + white rectangle) the complete
> overview at unqueue_mapview_updates.

That's definitely not "the" fix; it's horribly inefficient. 
unqueue_mapview_updates may be called many times because if there's 
nothing to be done it's not supposed to do anything.  But if it always 
copies the _entire_ overview to the screen then it becomes quite slow.

For instance this function is called before each animation.  Do we 
really need to redraw the overview each time?

jason