[Freeciv-Dev] Re: (PR#7385) overview isn't updated

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7385 >

Raimar Falke wrote:

>>I'd do the interface a bit differently:
>>
>>   dirty_overview() => sets dirty flag
>>     (or queue_overview_redraw())
>>
>>   flush_dirty_overview() => checks dirty flag, calls redraw
>>     (or unqueue_overview_redraw())
>>
>>   redraw_overview => doesn't check dirty flag
>>
>>flush_dirty_overview() can be called from inside unqueue_mapview_updates().
>>
>>In future the queue and dirty systems should be merged, though I'm not 
>>quite sure how to do this.
> 
> 
> I could do this but then the two cases above would be changed to:
>   dirty_overview();
>   flush_dirty_overview();
> which seems rather silly.

No, they'd still just call the redraw function.  To clarify:

   - queue() => sets queued flag
   - unqueue() => checks queued flag & calls redraw
   - redraw() => unchanged from current code

jason