[Freeciv-Dev] Re: (PR#2370) Path finding

["Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxx>]

On Sat, 15 Feb 2003, Raimar Falke wrote:

> > I rather liked bool return of construct_path, but I can live without it.
> 
> Why? The return value is in path->is_valid. If we get too long paths
> we have the following solutions:
>  - increase MAX_PATH_LEN (easy but increases memory usage)
>  - make it dynamic (cleanest but more work)
>  - handle it somehow in the caller (I like this least)

I know that it is in path->valid, but I still liked bool return value.

> > I didn't notice any extra omniscience handling.
> 
> Just look for "omniscience".

Ok, cool.

> > and a spurious mention of NOTHROUGH instead of DONT_LEAVE in
> > pf_danger_iterate_map.
> 
> I leave this to you.
> 
> > Otherwise, we only have to fix (x,y) <-> xy conversion and it's
> > ready imo.
> 
> I leave this to you.

You forgot a smiley, right? ;)

Anyway, all done, fixed, ship shape and Bristol fashion.  Did some 
renaming, run through indent.

Attached.

It now depends on (PR#3444) though.

G.

pf13.diff.gz
Description: pf13.diff.gz