[Freeciv-Dev] Re: (PR#2370) Path finding

["Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxx>]

On Thu, 13 Feb 2003, Raimar Falke wrote:

> > Please put it back.
> > TM_AVERAGE is the compatibility mode with the current warmap and it is 
> > also the most sensible of them all: it is faster than SAFE or LUCK and 
> > NONE is plain stupid -- it will think that riflemen will take 3 turns to 
> > climb a mountain.
> 
> Hmmm. I agree to keep this rolling.

Please put it back then ;)

> > BTW, SAFE and LUCK are not good names.  How about BEST and WORST?
> 
> Best and worst what? Path, cost, time?

BEST_TIME WORST_TIME ?

(same questions can be asked about "LUCK" and "SAFE", you know)

> > > Please add pf_get_path and pf_next_get_position since these are
> > > missing.
> > 
> > Okay, I will need to find your path-finding though.  pf_next_get_position 
> > is evil, btw.  When did I agree to ditch pf_next_get_cost? :((
> 
> You know that a lot of these can be implemented in terms of
> pf_next_get_position ?!

All of these + some extra.  And this "+ extra" annoys me.

But I put both functions in.  It compiles but they are untested.
I have no time now for testing, can you/Per do it, please?


> > But if you wish, sustitute ----- for =====.
> 
> Yes = is good.

Done.

Please also make sure _all_ functions we add have meaningful header 
comments.

G.

pf11.diff.gz
Description: pf11.diff.gz