Complete.Org: Mailing Lists: Archives: freeciv-dev: February 2003:
[Freeciv-Dev] Re: (PR#2370) Path finding
Home

[Freeciv-Dev] Re: (PR#2370) Path finding

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: rf13@xxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#2370) Path finding
From: "Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxx>
Date: Sat, 15 Feb 2003 15:00:52 -0800
Reply-to: rt@xxxxxxxxxxxxxx

Quoting Raimar Falke <rf13@xxxxxxxxxxxxxxxxx>:

> On Thu, Feb 13, 2003 at 09:48:04AM -0800, Gregory Berkolaiko wrote:
> > Please put it back then ;)
> 
> Done. Under the name of TM_CAPPED.

Good name.

> I also removed the bool return type of *construct_path*. Added some
> die()s. Added some comments. Move pqueue to common. Add omniscience
> handling.

I rather liked bool return of construct_path, but I can live without it.

I didn't notice any extra omniscience handling.

There is a strange change here:
==========================================================================
diff -Nurd -X clean/diff_ignore clean/common/shared.h path/common/shared.h
--- clean/common/shared.h       Fri Feb 14 17:28:53 2003
+++ path/common/shared.h        Sat Feb 15 11:14:31 2003
@@ -19,7 +19,7 @@
 #include <posix/be_prim.h>
 #define __bool_true_false_are_defined 1
 #else
-#ifdef HAVE_STDBOOL_H
+#ifdef HAVE_STDBOOL_H2
 #include <stdbool.h>
 #else /* Implement <stdbool.h> ourselves */
 #undef bool
==========================================================================

and a spurious mention of NOTHROUGH instead of DONT_LEAVE in 
pf_danger_iterate_map.


Otherwise, we only have to fix (x,y) <-> xy conversion and it's ready imo.

G.



[Prev in Thread] Current Thread [Next in Thread]