[Freeciv-Dev] Re: (PR#2370) Path finding

["Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxx>]

On Thu, 13 Feb 2003, Raimar Falke wrote:

> macro, wrong function types and so on. I also removed TM_AVERAGE
> because I think that there is no clean semantic.

Please put it back.
TM_AVERAGE is the compatibility mode with the current warmap and it is 
also the most sensible of them all: it is faster than SAFE or LUCK and 
NONE is plain stupid -- it will think that riflemen will take 3 turns to 
climb a mountain.

BTW, SAFE and LUCK are not good names.  How about BEST and WORST?

> Please add pf_get_path and pf_next_get_position since these are
> missing.

Okay, I will need to find your path-finding though.  pf_next_get_position 
is evil, btw.  When did I agree to ditch pf_next_get_cost? :((

> Cleaned up a lot. I battled over naming it "priority queue" or
> "heap". Looks like both are equal common.
> 
> I think that pqueue should be moved to common.

Ack.  Job for Per :)

> There is currently no standard for section comments. You used
> /* -------------------- generating the map ------------------------ */
> I used in cm.c
> /****************************************************************************
>                            algorithmic functions
> *****************************************************************************/
> 
> IMHO these - are bad because I can no longer search with "---" for the
> next file in a diff.

Ah, poor you :)
Now you have to search for "+++".

But if you wish, sustitute ----- for =====.

The point is, section separators should be different from function 
headers.

G.