[Freeciv-Dev] Re: (PR#2370) Path finding

["Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxx>]

On Tue, 11 Feb 2003, Raimar Falke via RT wrote:

> > Now I'm wondering, didn't you ever write any code which actually made path
> > finding work inside the game?
> 
> No. AFAIK Greg and I only used plain timing measures or used the
> warmap call to also trigger a pf call.

I adapted old explorer code to use it but then it disappeared in the 
testing / comparing stages.

> Problems:
>  - quality of path_finding.c (later)

quality of path_finding.c is superb!  Five stars!  Too good so it stands
out, so I guess that must be fixed...

>  - name of path_tools

changed to pf_tools

>  - pqueue:
>    * no comment at all what this is (also bad filename IMHO)
>    * PQDATUM* suggests a flexibility which isn't there
>    * INIT_ITEMS, *tiny* shouldn't be public

please fix

>  - get_move_costs2 and update_move_costs2 were used by my
>  implmentation. remove it.

done

>  - data/nation/Makefile.am is in the diff

removed

>  - noise in server/stdinhand.c

removed

Result attached.

G.

pf9.diff.gz
Description: pf9.diff.gz