[Freeciv-Dev] Re: Assertion failed: missing > 0, file plrhand.c, line 383

[Mike Kaufman <mkaufman@xxxxxxxxxxxxxx>]

On Wed, Jan 16, 2002 at 07:03:57PM +0000, Gregory Berkolaiko wrote:
>  --- Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> wrote: 
> > On Wed, Jan 16, 2002 at 04:36:57PM +0000, Gregory Berkolaiko wrote:
> > >  --- Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> wrote: 
> > > > On Tue, Jan 15, 2002 at 02:56:02PM -0800, Paul Zastoupil wrote:
> > > > > Well I just keep running games cause I like to find bugs.
> > > > > 
> > > > > Assertion failed: missing > 0, file plrhand.c, line 383
> > > > 
> > > > And I fought it was a straightforward change.
> > > 
> > > It can easily happen that missing get < 0.  Line 388:
> > >   plr->research.bulbs_researched += (bulbs - missing);
> > > There is no check if this addition pays for a new tech.  So next time
> > we
> > > go into update tech missing can become <0
> > 
> > Yes but this means that this city produce more bulbs than what is
> > required for a complete tech. I decided that this is unlikely. So I
> > add the assert and not a while(have_enough_point_for_another_tech).
> 
> Alternatively it might mean that the next tech costs very little which is
> perfectly possible with tech_leakage set.

even without server settings, a mega city with the appropriate improvements can
produce plenty of bulbs.

-mike

> 
> but I don't think a while loop is good.
> you should still restrict to one tech a turn, I think (except for
> Darwin).
> or will it then be one tech a city, if you just remove assert?
> 
> also I am not sure if update_tech is a sole source of negative missing.
> what if user decides to go for a different (cheaper -- it is possible
> under new tech system) tech?
> 
> good luck,
> G.
> 
> __________________________________________________
> Do You Yahoo!?
> Everything you'll ever need on one web page
> from News and Sport to Email and Music Charts
> http://uk.my.yahoo.com