[Freeciv-Dev] Re: Assertion failed: missing > 0, file plrhand.c, line 383

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Thu, Jan 17, 2002 at 11:57:56PM -0500, Ross W. Wetmore wrote:
> At 07:48 PM 02/01/16 +0100, Raimar Falke wrote:
> >On Wed, Jan 16, 2002 at 04:36:57PM +0000, Gregory Berkolaiko wrote:
> >>  --- Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> wrote: 
> >> > On Tue, Jan 15, 2002 at 02:56:02PM -0800, Paul Zastoupil wrote:
> >> > > Well I just keep running games cause I like to find bugs.
> >> > > 
> >> > > Assertion failed: missing > 0, file plrhand.c, line 383
> >> > 
> >> > And I fought it was a straightforward change.
> >> 
> >> It can easily happen that missing get < 0.  Line 388:
> >>   plr->research.bulbs_researched += (bulbs - missing);
> >> There is no check if this addition pays for a new tech.  So next time we
> >> go into update tech missing can become <0
> >
> >Yes but this means that this city produce more bulbs than what is
> >required for a complete tech. I decided that this is unlikely. So I
> >add the assert and not a while(have_enough_point_for_another_tech).
> 
> I've done it on occasion - it is nt that difficult. And it is certainly 
> possible to setup a valid scenario that can do it. Sometimes a rich caravan 
> will do wonders for your research speed, as well :-).
> 
> Also, have you considered the case where you get a bonus tech

No problem.

> , or some combination of getting a tech you are almost done
> researching and a research bonus at the same time?

How can you get a research bonus?

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "We just typed make..."
    -- Stephen Lambrigh, Director of Server Product Marketing at Informix,
                         about porting their Database to Linux