[Freeciv-Dev] Re: Assertion failed: missing > 0, file plrhand.c, line 383

[Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx>]

 --- Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> wrote: 
> On Tue, Jan 15, 2002 at 02:56:02PM -0800, Paul Zastoupil wrote:
> > Well I just keep running games cause I like to find bugs.
> > 
> > Assertion failed: missing > 0, file plrhand.c, line 383
> 
> And I fought it was a straightforward change.

It can easily happen that missing get < 0.  Line 388:
  plr->research.bulbs_researched += (bulbs - missing);
There is no check if this addition pays for a new tech.  So next time we
go into update tech missing can become <0

So I think the assert is incorrect.

> 
> > #0  0xff21b638 in _libc_kill () from /usr/lib/libc.so.1
> > #1  0xff1b5644 in abort () from /usr/lib/libc.so.1
> > #2  0xff1b58e8 in _assert () from /usr/lib/libc.so.1
> > #3  0x40d20 in update_tech (plr=0x124230, bulbs=29) at plrhand.c:390
> > #4  0x2ecb4 in update_city_activity (pplayer=0x124230,
> pcity=0x3584a8)
> >     at cityturn.c:1287
> > #5  0x2d298 in update_city_activities (pplayer=0x124230) at
> cityturn.c:410
> > #6  0x40458 in update_player_activities (pplayer=0x124230) at
> plrhand.c:173
> > #7  0x15440 in end_turn () at srv_main.c:420
> > #8  0x177a0 in main_loop () at srv_main.c:1729
> > #9  0x17cf0 in srv_main () at srv_main.c:1971
> > #10 0x11f1c in main (argc=0, argv=0xffbef9cc) at civserver.c:147
> > 
> > 
> > Its reproducable.  I have a savegame, and the core.
> 
> Please give me the savegame.
> 
>       Raimar
> 
> -- 
>  email: rf13@xxxxxxxxxxxxxxxxx
>   This message has been ROT-13 encrypted twice for extra security.
>  

__________________________________________________
Do You Yahoo!?
Everything you'll ever need on one web page
from News and Sport to Email and Music Charts
http://uk.my.yahoo.com