Complete.Org: Mailing Lists: Archives: freeciv-dev: January 2002:
[Freeciv-Dev] Re: Assertion failed: missing > 0, file plrhand.c, line 38
Home

[Freeciv-Dev] Re: Assertion failed: missing > 0, file plrhand.c, line 38

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: rf13@xxxxxxxxxxxxxxxxxxxxxx
Cc: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: Assertion failed: missing > 0, file plrhand.c, line 383
From: Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx>
Date: Thu, 17 Jan 2002 16:08:20 +0000 (GMT)

 --- Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> wrote: 
> On Thu, Jan 17, 2002 at 02:45:23PM +0000, Gregory Berkolaiko wrote:
> >  --- Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> wrote: 
> > [future tech cleanup]
> >
> > Can you use your new and lovely get_tech_name instead of old and ugly
> > if-elseif-else construction below??
> 
> I would have done so if it would be this easy.
> 
> > > +      } else {
> > > + notify_player(plr, _("Game: Learned Future Tech. %d.  "
> > > +                      "Researching Future Tech. %d."),
> > > +               plr->future_tech, (plr->future_tech) + 1);
> 
> Problem 1: the static buffer of get_tech_name can't be reused
> 
> Problem 2: if could be written with another buffer and two calls to
> get_tech_name to assemble the string. But this is also ugly.

Ah, I think I understand.  The problem is in using the get_tech_name
twice in the call to the same function?

Maybe then split into two notifies:
Game: Learned %s
Game: Researching %s

G.

__________________________________________________
Do You Yahoo!?
Everything you'll ever need on one web page
from News and Sport to Email and Music Charts
http://uk.my.yahoo.com


[Prev in Thread] Current Thread [Next in Thread]