[Freeciv-Dev] Re: Assertion failed: missing > 0, file plrhand.c, line 383

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Thu, Jan 17, 2002 at 04:08:20PM +0000, Gregory Berkolaiko wrote:
>  --- Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> wrote: 
> > On Thu, Jan 17, 2002 at 02:45:23PM +0000, Gregory Berkolaiko wrote:
> > >  --- Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> wrote: 
> > > [future tech cleanup]
> > >
> > > Can you use your new and lovely get_tech_name instead of old and ugly
> > > if-elseif-else construction below??
> > 
> > I would have done so if it would be this easy.
> > 
> > > > +      } else {
> > > > +       notify_player(plr, _("Game: Learned Future Tech. %d.  "
> > > > +                            "Researching Future Tech. %d."),
> > > > +                     plr->future_tech, (plr->future_tech) + 1);
> > 
> > Problem 1: the static buffer of get_tech_name can't be reused
> > 
> > Problem 2: if could be written with another buffer and two calls to
> > get_tech_name to assemble the string. But this is also ugly.
> 
> Ah, I think I understand.  The problem is in using the get_tech_name
> twice in the call to the same function?

Yes.

> Maybe then split into two notifies:
> Game: Learned %s
> Game: Researching %s

Just because we can't use the shiny new function get_tech_name in a
non-ugly way: no.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Using only the operating-system that came with your computer is just
  like only playing the demo-disc that came with your CD-player."