[Freeciv-Dev] robert bugs patch (was: Multiple patches)

[Jeff Mallatt <jjm@xxxxxxxxxxxx>]

At 2000/05/25 21:30 , Robert Rendell wrote:
>
>bugs.diff
>
>    This patch fixes four bugs...
>       * the memory allocated for worklist names in the xaw and gtk
>               clients could potentially be overrun (this patch actually
>               only fixes the xaw client, because the gtk client is fixed
>               in the "worklist.diff" patch)
>       * isnt_terrain_near_tile tested whether *any* tile nearby wasn't of
>               the nominated type, rather than whether *every* tile
>               wasn't.  That is, if you called
>               isnt_terrain_near_tile(x,y,T_OCEAN), and there was
>               grassland (say) to the north-west of (x,y), it would return
>               true, even if there was ocean everywhere else.
>               (isnt_terrain_near_tile isn't actually called anywhere in
>               the code, but it still should be correct.)
>       * an exploitable bug: changing a city's production to something of
>               the same type would set turn_changed_target, which meant
>               that further changes could be made in the same turn to
>               productions of different types without incurring any
>               resource loss at all.
>       * not strictly a bug, but incorrect behaviour: when a unit changed
>               home cities, the previous home and the new home didn't get
>               recalced.

Version skew led to it not applying correctly.  The attached patch updates
to the latest CVS.

Also, added the first fix for the gtk client as well.  The two clients
should be maintained in parallel, as much as possible.

All of these look good to me.

bugs-1.diff
Description: Text document

jjm