[Freeciv-Dev] Re: (PR#2521) general effects framework

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=2521 >

Jason Short wrote:

> My suggestion was that enable_space and enable_nuke - both of which 
> allow production of something based on a certain flag - can be merged 
> into one effect.
> 
> So for Manhatten it would be
> 
>    Effect = ProvidesFlag
>     extra data: survives
>     extra data: flag name "CanNuke"
> 
> and for nukes
> 
>    Effect = RequiresFlag
>      extra data: flag name "CanNuke"
> 
> it is then trivial to make the list of such "flags" into a bitvector.

Err, the "survives" flag for this effect shouldn't be needed since such 
flags should always survive (otherwise they could just be 
straightforward requirements).

In fact you may want to declare that ONLY these flags survive.

jason