[Freeciv-Dev] (PR#7095) No Capital, and can't build one..

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7095 >

> [ue80@xxxxxxxxxxxxxxxxxxxxx - Thu Jan 22 18:37:31 2004]:

> > I see no reason not to include a warning - for this rare cases when
> > you really *want* to sell your palace, one click more won't do you
> any
> > bad. Playing games is not like fiddling with a root account - one
> > should be stopped from shooting oneself in the foot unless explictly
> > told not to.
> 
> Yes, it's not fiddling with a root account. You can restart and retry.
> Ask other players and learn.
> 
> Freeciv is a game, and the game can't prevent you from making errors.
> You have to learn to make good decission. When don't want to have the
> chance to make a bad decission watch games from top-players, or from
> the
> AI.
> 
> Think i played more games where i had to sell my palace in an
> emergency
> case than any other player selled it as fault.
> 
> And one click is really very much when you are in time preasure.

No need to argue - we can include a warning without any extra clicking.
 Of course the player may not bother to read the warning, but this
should be quite sufficient as an I-told-you-so.

You may be able to come up with a better message, however.  And
certainly this can be extended to other clients.

jason

Index: client/gui-gtk/mapctrl.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/client/gui-gtk/mapctrl.c,v
retrieving revision 1.94
diff -u -r1.94 mapctrl.c
--- client/gui-gtk/mapctrl.c    2004/01/04 00:42:23     1.94
+++ client/gui-gtk/mapctrl.c    2004/01/21 05:42:17
@@ -368,7 +368,7 @@
   if (can_client_change_view() && ev->button == 3) {
     center_tile_mapcanvas(xtile, ytile);
   } else if (can_client_issue_orders() && ev->button == 1) {
-    do_unit_goto(xtile, ytile);
+    do_map_click(xtile, ytile, SELECT_POPUP);
   }
 
   return TRUE;
Index: client/gui-gtk-2.0/mapctrl.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/client/gui-gtk-2.0/mapctrl.c,v
retrieving revision 1.36
diff -u -r1.36 mapctrl.c
--- client/gui-gtk-2.0/mapctrl.c        2004/01/04 00:42:24     1.36
+++ client/gui-gtk-2.0/mapctrl.c        2004/01/21 05:42:17
@@ -348,7 +348,7 @@
   if (can_client_change_view() && (ev->button == 3)) {
     center_tile_mapcanvas(xtile, ytile);
   } else if (can_client_issue_orders() && (ev->button == 1)) {
-    do_unit_goto(xtile, ytile);
+    do_map_click(xtile, ytile, SELECT_POPUP);
   }
 
   return TRUE;
Index: client/gui-xaw/mapctrl.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/client/gui-xaw/mapctrl.c,v
retrieving revision 1.81
diff -u -r1.81 mapctrl.c
--- client/gui-xaw/mapctrl.c    2004/01/04 00:42:24     1.81
+++ client/gui-xaw/mapctrl.c    2004/01/21 05:42:17
@@ -290,7 +290,7 @@
   overview_to_map_pos(&xtile, &ytile, event->xbutton.x, event->xbutton.y);
 
   if(ev->button==Button1)
-    do_unit_goto(xtile,ytile);
+    do_map_click(xtile, ytile, SELECT_POPUP);
   else if(ev->button==Button3)
     center_tile_mapcanvas(xtile, ytile);
 }