[Freeciv-Dev] Re: Extended connect dialog (PR#977)

["Mike Kaufman" <kaufman@xxxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=977 >

On Mon, Jan 19, 2004 at 01:10:44AM -0800, Jason Short wrote:
> 
> - Your translation code is wrong.
> 
ah, so someone finally explains...

> - Why do the packets you introduce require explicit (non-delta) 
> handling?  Raimar?

the handling is explicit, but they are delta packets. the reason for these
flags: handle-per-conn,no-handle is that these packets are sent before
players are assigned. They must be handled on a connection rather than
player basis. They must also be handled before the !pplayer check is
performed. I've talked to Raimar about added another packet handler for
these type of packets. He agrees.

> - /* FIXME: may not be long enough? use MAX_PATH? */
> 
> You should use PATH_MAX or (better) dynamically assign arrays that store 
> a path.  Note that PATH_MAX doesn't exist on all systems; if it doesn't 
> exist then the path length is unbounded.  (I'm pretty sure it's 
> PATH_MAX, defined in limits.h, not MAX_PATH.)

True enough. I must have gotten discombobulated, cause I wanted to use the
OS define... I don't think that dynamically assigned is going to work here
cause you have to use the array in getopt.

Q: Raimar, do we have array maxes in delta?
   Will the dataio put_string function automatically do a strlen?

> - This patch introduces a lot of design that needs documentation, 
> probably in doc/HACKING.  Better code comments will help too: not just 
> saying what a function does but how it fits into the overall design.

Ok.