[Freeciv-Dev] Re: (PR#7259) new function tile_has_river

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7259 >

Jason Short wrote:

>>So we agree that we want to remove the T_RIVER terrain type?! I'm for
>>it. Less special cases.
> 
> 
> Drawbacks:
> 
> - Incompatability with civ1 tilesets.
> 
> - Future incompatability with civ1 saved games.
> 
> Does anyone care about this?  I suspect not.

Hmm, and one other consideration: this may be a slippery-slope toward 
removing terrain types.

In civ3 forest is treated as a special.  Forest can be on top of hills, 
mountains, grasslands, plains, tundra, etc.  Removing T_FOREST is 
feasible but may invalidate civ2 tilesets (which is bad).  The 
alternative is to introduce a method for handling forests as either 
terrain or special.  But if such a thing existed it might as well be 
used for rivers as well.

jason