[Freeciv-Dev] Re: (PR#2641) islands from the client's point of view

["Raimar Falke via RT" <rt@xxxxxxxxxxxxxx>]

On Fri, Jan 24, 2003 at 09:52:38PM -0800, Mike Kaufman via RT wrote:
> 
> here is the [long] awaited patch for server-controlled
> pplayer-point-of-view continents. It accomplishes this via a
> packet_continent_info packet which the server sends to the client when it
> needs to update numbering. The client itself has access to a recursive
> continent numbering function, so the server only needs to send one tile of
> a continent for all the tiles on the continent to be renumbered.
> 
> there is one slight behavior change: if a player establishes a a trade
> route with another player and that player doesnt know the caravan's
> homecity, then that city is shown to that player. From Davide's
> informational standpoint this is good, and it's necessary to maintain
> continental integrity.
> 
> I've attached two test savegames to test the patch. log in as 'kauf' and
> 'kauf2'

Why do we need num_continents in the paket?

You replaced unsigned short int with signed short int. Why? Shouldn't
we introduce a typedef for this?

I don't like this RESET_CONTINENTS special case. Can't it be done in
another way?

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "We just typed make..."
    -- Stephen Lambrigh, Director of Server Product Marketing at Informix,
                         about porting their Database to Linux