[Freeciv-Dev] Re: (PR#2641) islands from the client's point of view

["Raimar Falke via RT" <rt@xxxxxxxxxxxxxx>]

On Sat, Jan 25, 2003 at 09:44:37AM -0800, Mike Kaufman via RT wrote:
> On Sat, Jan 25, 2003 at 08:46:07AM -0800, Raimar Falke via RT wrote:
> > > 
> > Mhh I didn't looked at the code but IMHO there should no client
> > recycling. The server just sends the seed(s) and the client renumbers.
> > 
> > So when and why does the client recycle continent numbers?
> 
> say you have 4 conts and a unit discovers that 2 and 3 are the same, then 3
> is renumbered to 2, so you have 1,2,4. The server will then recycle 4 to 3.
> So will the client, because it knew that the continent set to 2 was
> previously a 3. If the server had to tell the server this, then the server
> would have to search the entire map for a 4 tile and tell the client to
> renumber it. This of course is possible, but wasteful, but if we're going
> to do this, we should ditch recycle_continent_num altogether. I'll check
> this.

I still have not seen any numbers who frequent renumbers are, but
... What do you think the following: we clear the info all the time a
continent is merged or renumbered. This way the packet changes to an
array of <x,y,continent>. The client part is easy. But also here has
the server the task to find the seed positions to cover all fragments
known by the client.

> > Since a tile is either land or non-land this is not useful. What would
> > be usefull if you create a union. But also this has nothing to do with
> > the patch.
> 
> say I want to number inland lakes, for example to see if I want to build
> that battleship in the city next to an ocean only 10 tiles big? or if that
> battleship can reach a particular target?

And? I don't see the point. You can reuse ptile->continent or for more
clarification we can do the union.

> Or if we ever decide to expand the kinds of ocean tiles.

And how is this related to continent/ocean numbering?

> There may be many reasons to do so. anyhow, with the current and
> forseeable restrictions on map size, 32000 continents is plenty.

I still don't see the point of the change.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "This is Linux Country. On a quiet night, you can hear Windows reboot."