Complete.Org: Mailing Lists: Archives: freeciv-dev: November 2001:
[Freeciv-Dev] Re: PATCH: AI cleanup Version 2

[Freeciv-Dev] Re: PATCH: AI cleanup Version 2

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Petr Baudis <pasky@xxxxxxxxxxx>
Cc: Raahul Kumar <raahul_da_man@xxxxxxxxx>, Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx>, freeciv development list <freeciv-dev@xxxxxxxxxxx>
Subject: [Freeciv-Dev] Re: PATCH: AI cleanup Version 2
From: Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>
Date: Sat, 24 Nov 2001 13:07:27 +0100
Reply-to: rf13@xxxxxxxxxxxxxxxxxxxxxx

On Sat, Nov 24, 2001 at 11:43:30AM +0100, Petr Baudis wrote:
> > To be honest I'm a bit lost. Suddenly three people work on the ai
> > movement code and produce patches like there is no tomorrow (which is
> > good). How does all the patches relate to each other?
> My patch applies on the top of Raahul's one. It corrects indendation
> of one function he changed, as it is broken, and does more cleanups and
> adds some comments.
> I attach hopefully the final version of it ;-). I added some comments,
> removed some indendation changes and made even more variables local.

My job is it to verify such patches. It would make my job much easier
if you split such patches. For example in "move comments around",
"rename variables", "move variables around" and "add comments". The
patch below it is still ok but I just want to show my position.

Also note that the patch contains extra reformatting noise.


 email: rf13@xxxxxxxxxxxxxxxxx
 "When C++ is your hammer, everything looks like a thumb."
    -- Steven M. Haflich

[Prev in Thread] Current Thread [Next in Thread]