[Freeciv-Dev] Re: Coding Guideline RFC

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Sun, Nov 25, 2001 at 05:03:54PM +0000, Gregory Berkolaiko wrote:
I have another two:

7: merge declaration lines:

  /* A */
  int city_buy_cost(struct city *pcity)
  {
    int total,cost;
    int build=pcity->shield_stock;

  /* B */
  int city_buy_cost(struct city *pcity)
  {
    int total, cost, build = pcity->shield_stock;

8: double deref:

  /* A */
  int foo(struct city *pcity)
  {
     struct player *owner=city_owner(pcity);
     struct nation_type *nation=get_nation_by_plr(owner);

  /* B */
  int foo(struct city *pcity)
  {
     struct player *owner=city_owner(pcity);
     struct nation_type *nation;

     nation=get_nation_by_plr(owner);

My vote: 7b, 8a

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "That's fundamental game play!  My main enemy is *ALWAYS* fighting 
  a 4-front war.  I make sure of it!"
    -- Tony Stuckey, freeciv-dev