[Freeciv-Dev] Coding Guideline RFC

[Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx>]

 --- Gregor Zeitlinger <zeitling@xxxxxxxxxxxxxxxxxxxxxxx> wrote: 
> On Sun, 25 Nov 2001, Petr Baudis wrote:
> <snip>
> 
> I agree on all issues with Petr, but I thought the "indent -kr -2" has
> already defined that? Am I mistaken?

indent -kr -i2 fixes some of the issues Petr raised (mostly amount of
whitespace around).

Below is a list of questions that indent _does_not_ address.  This list
is "indent -kr -i2"-invariant.

So shall we:
1. Think hard about other possible issues.
2. Vote (or, given that Raimar is the formatting Kerberos, just let him
decide).
3. Put the answers in "How to contribute" on www.freeciv.org
?

Best,
G.

P.S. I vote 1A 2B 3B 4A 5- 6A
========================================================================

/*************** 
 * 1: init vars 
 ***************/

/* A */
int foo1a(struct city *punit)
{
  int x = punit->x;
}

/* B */
int foo1b(struct city *punit)
{
  int x;

  x = punit->x;
}


/**************************
 * 2: empty line after vars 
 **************************/

/* A */
int foo2a(void)
{
  int x;
  x = 3;
}

/* B */
int foo2b(void)
{
  int x;

  x = 3;
}


/****************
 * 3: comments 
 ****************/

/* A */
int foo3a(int x)
{
  x = 3;                        /* assign 3 to x */
}

/* B */
int foo3b(int x)
{
  /* assign 3 to x */
  x = 3;
}


/**************************
 * 4: extra {} on iterates 
 **************************/
int foo4(struct city *pcity)
{

  /* A */
  unit_list_iterate(pcity->units_supported, punit) {
    kill(punit);
  } unit_list_iterate_end;

  /* B */
  unit_list_iterate(pcity->units_supported, punit)
      kill(punit);
  unit_list_iterate_end;
}


/****************************************** 
 * 5: unnecessary braces after conditionals 
 ******************************************/
int foo5(int x)
{

  /* A */
  if (x == 3) {
    return;
  }

  /* B */
  if (x == 4)
    return;
}


/**************************************************** 
 * 6: unnecessary braces after conditionals with else 
 ****************************************************/
int foo6(int x)
{

  /* A */
  if (x == 3) {
    return 1;
  } else {
    return 0;
  }

  /* B */
  if (x == 4)
    return 1;
  else
    return 0;

}


__________________________________________________
Do You Yahoo!?
Everything you'll ever need on one web page from News and Sport to Email and 
Music Charts
http://uk.my.yahoo.com