[Freeciv-Dev] Re: New city dialog

[Daniel Sjölie <deepone@xxxxxxxxxx>]

On 2001-10-26 14:18:19, Pieter J. Kersten wrote:
> On Fri, 26 Oct 2001, Daniel Sjölie wrote:
> 
> > On 2001-10-26 12:12:02, Pieter J. Kersten wrote:
> > > In response on my own mail:
> > >
> > > On Fri, 26 Oct 2001, Pieter J. Kersten wrote:
> > >
> > > > LS,
> > > >
> > > > It seems there are some translation problems in the new city dialog.
> > > > Al the tabs remain untranslated.
> > >
> > > In the files freeciv/client/gui-gtk/{menu.c|citydlg.c} there are quite a
> > > few strings marked with N_() and thus remain explicitly untranslated.
> > > Why?
> >
> > When you initiate variables with strings (eg structs, arrays) you're not
> > allowed to do function calls... So you use N_() to mark the string for
> > translation and then you'll have to remember to do _() on the variable
> > when you actually use it... Seems we missed that last step in a few
> > places...
> 
> Ok, I've made a small patch on citydlg.c to fix just that. It fixes the
> tabs problem, not the string 'Currently building:'. I'll have to dive
> deeper for that problem. Don't expect that to happen anytime soon, so feel
> free to solve it yourself :-)

You can use _() directly when assigning directly to a variable it seems
(in the cases at hand anyway), arrays and structs are "different"... ;)

So... The attached patch should fix all translation misses you told me
about... I did not really test it or add happiness.c to POTFILES though
since I'm not familiar with that stuff...

/Daniel

-- 
Now take a deep breath, smile and don't take life so seriously... :)

translation_fix.diff
Description: Text document