[Freeciv-Dev] Re: (PR#8914) ruleset starting units list

["Per Inge Mathisen" <per@xxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8914 >

On Tue, 8 Jun 2004, Jason Short wrote:
> > Here's an implementation of startunits as a server string variable.
> >
> > startunits defaults to "cwx"
> >
> > Characters and corresponding roles:
> > c: F_CITIES
> > w: F_SETTLERS
> > x: L_EXPLORER
> > k: F_GAMELOSS
> > s: F_DIPLOMAT
> > f: L_FERRYBOAT
> > d: L_DEFEND_GOOD
> > a: L_ATTACK_FAST
> > A: L_ATTACK_STRONG

I think this confuses the role of roles and flags. Not that this is a
clear cut issue anyway, but we should not make it worse. I would say only
roles here, and if you need more roles, just add 'em.

> > -There was a minor bug in aidiplomat.c which caused a crash when a
> > diplomat unit had nothing to do. This was fixed.
>
> I don't understand. Why does the original code use the comma?  Where
> does "map" come from? Why is the same method used 2 lines above? How
> could "map" ever be NULL? Per and Greg, can you explain?

I can't recall adding this - it is a way of coding that is totally alien
to me. Must be Greg's fault somehow! :-)

  - Per