[Freeciv-Dev] (PR#8949) drawing bug with moving units

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8949 >

I pointed this bug out in another patch but forgot to send a bug just 
for it.  Any moving unit is likely not to be drawn correctly.

This is a pretty big bug; I'm surprised nobody's reported this yet (it's 
been around for over a week)...

jason

Index: client/packhand.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/client/packhand.c,v
retrieving revision 1.378
diff -u -r1.378 packhand.c
--- client/packhand.c   10 Jun 2004 01:04:52 -0000      1.378
+++ client/packhand.c   10 Jun 2004 18:38:36 -0000
@@ -1093,7 +1093,10 @@
 
       /* Show where the unit is going. */
       do_move_unit(punit, packet_unit);
-      if (punit->transported_by != -1) {
+      if (punit->transported_by == -1) {
+       /* Repaint if the unit isn't transported.  do_move_unit erases the
+        * unit's old position and animates, but doesn't update the unit's
+        * new position. */
        repaint_unit = TRUE;
       }