[Freeciv-Dev] Re: (PR#8914) ruleset starting units list

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8914 >

Jason Short wrote:

>>-There was a minor bug in aidiplomat.c which caused a crash when a
>>diplomat unit had nothing to do.  This was fixed.
> 
> I don't understand.  Why does the original code use the comma?  Where 
> does "map" come from?  Why is the same method used 2 lines above?  How 
> could "map" ever be NULL?  Per and Greg, can you explain?

Ahh, maybe now I understand.  The use of "map" is incorrect.  However 
the use of find_closest_owned_city is also wrong since it goes only by 
real_map_distance not by travel time.  So the correct function (whatever 
that is) _should_ take a map parameter.

jason