Complete.Org: Mailing Lists: Archives: freeciv-dev: June 2004:
[Freeciv-Dev] Re: (PR#8632) Easy way to set map size with auto ratios (s
Home

[Freeciv-Dev] Re: (PR#8632) Easy way to set map size with auto ratios (s

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: mburda@xxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#8632) Easy way to set map size with auto ratios (seteables if desired)
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Wed, 2 Jun 2004 13:41:33 -0700
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8632 >

Marcelo Burda wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=8632 >
> 
> LAST CHANGE
> drop changes in aigoto and citytools

OK, but...

If the ratio is not a user (server) option, then we don't need a global 
map.ratio value.  We don't need the "100" default value.  We don't need 
the X + 10Y ratio system.  We don't need the gcf() function.  We can 
just use the ratio values straight out of the "default ratio" array. 
And this array should (probably) be an int[4][2] rather than an int[4].

In short, none of the error handling code for building the ratio is needed.

jason




[Prev in Thread] Current Thread [Next in Thread]