[Freeciv-Dev] Re: (PR#8632) Easy way to set map size with auto ratios (seteables if desired)

["Marcelo Burda" <mburda@xxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8632 >

Le mar 01/06/2004 à 02:29, Jason Short a écrit :
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=8632 >
> 
> Marcelo Burda wrote:
> 
> > -  struct pqueue *rp_queue = pq_create(MAP_MAX_WIDTH);
> > +  struct pqueue *rp_queue = pq_create(MAP_WIDTH);
> 
> But why are these changes necessary?  And is this particular change even 
> correct?
> 
Hi, 
First i was try to drop all arbritrary bigs MAP_MAX_WIDTH, but this are
not posible in one place where this was used to define global array.
then i was force to redefine MAP_MAX_WIDTH. to avoid to touch too much
the code.
i think there we need a more or les arbritray moderate big number.
MAP_WIDTH, is probably ok  if we want get a more safe value. this is not
realy related to width but related to size of the map. 

kip MAP_WIDTH is safe if ratio are good!, but, first, ratio can be
extreme, second when this code was writed MAP_MAX_WIDTH > MAP_HEIGHT and
3th this is not realy related to WIDTH, i will change this on
MAP_MAX_LINEAR_SIZE. this will avoid future mistake

then a change is nessesary

but this change is not absolutly needed in this patch. i can make a
separate patch for this.
> jaosn
-- 
 . /  .     '    ,    .      (*)   '        `     '      `    .    
  |    ,  |   `     ,     .      ,   '  Marcelo Julián Burda      .
 /  '     \     `     \@_     '      .        '      `        '    
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~