Complete.Org: Mailing Lists: Archives: freeciv-dev: May 2004:
[Freeciv-Dev] (PR#8624) New clima function to best handle terrain place,
Home

[Freeciv-Dev] (PR#8624) New clima function to best handle terrain place,

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: mburda@xxxxxxxxx
Subject: [Freeciv-Dev] (PR#8624) New clima function to best handle terrain place, used to place poles.
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Thu, 27 May 2004 21:16:27 -0700
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8624 >

> [mburda - Thu May 27 15:35:37 2004]:

> !!! that's all ?!!!

Very close.

A few very small things:

- Put MAX_TEMP in mapgen.c not mapgen.h.

- Change this line:

    dist = topo_has_flag(TF_ISO) ? (2 * dist) : dist;

to
    dist *= topo_has_flag(TF_ISO) ? 2 : 1;

- Change the data passed to rand_map_pos filtered from an int[3] to a
struct {int x, y; enum tile_terrain_type t;}.  Or something like that.

- Any macro that you define *within a function* should be #undefined
before the end of that function.  SQSIZE and ICE_BASE_LEVEL should be
outside of any function I think.  (P.S. Why ICE_BASE_LEVEL not just
ICE_LEVEL?)

I think the rest is okay.  But I may find something else.  I'll look
over it very closely before committing.

jason




[Prev in Thread] Current Thread [Next in Thread]