[Freeciv-Dev] (PR#8624) New clima function to best handle terrain place,
[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
<URL: http://rt.freeciv.org/Ticket/Display.html?id=8624 >
> [mburda - Thu May 27 15:35:37 2004]:
> !!! that's all ?!!!
Very close.
A few very small things:
- Put MAX_TEMP in mapgen.c not mapgen.h.
- Change this line:
dist = topo_has_flag(TF_ISO) ? (2 * dist) : dist;
to
dist *= topo_has_flag(TF_ISO) ? 2 : 1;
- Change the data passed to rand_map_pos filtered from an int[3] to a
struct {int x, y; enum tile_terrain_type t;}. Or something like that.
- Any macro that you define *within a function* should be #undefined
before the end of that function. SQSIZE and ICE_BASE_LEVEL should be
outside of any function I think. (P.S. Why ICE_BASE_LEVEL not just
ICE_LEVEL?)
I think the rest is okay. But I may find something else. I'll look
over it very closely before committing.
jason
- [Freeciv-Dev] Re: (PR#8624) New clima function to best handle terrain place, used to place poles., (continued)
- [Freeciv-Dev] Re: (PR#8624) New clima function to best handle terrain place, used to place poles., Marcelo Burda, 2004/05/23
- [Freeciv-Dev] Re: (PR#8624) New clima function to best handle terrain place, used to place poles., Jason Short, 2004/05/23
- [Freeciv-Dev] Re: (PR#8624) New clima function to best handle terrain place, used to place poles., Marcelo Burda, 2004/05/23
- [Freeciv-Dev] Re: (PR#8624) New clima function to best handle terrain place, used to place poles., Marcelo Burda, 2004/05/23
- [Freeciv-Dev] Re: (PR#8624) New clima function to best handle terrain place, used to place poles., Marcelo Burda, 2004/05/24
- [Freeciv-Dev] Re: (PR#8624) New clima function to best handle terrain place, used to place poles., Marcelo Burda, 2004/05/25
- [Freeciv-Dev] Re: (PR#8624) New clima function to best handle terrain place, used to place poles., Marcelo Burda, 2004/05/26
- [Freeciv-Dev] (PR#8624) New clima function to best handle terrain place, used to place poles., Jason Short, 2004/05/27
- [Freeciv-Dev] Re: (PR#8624) New clima function to best handle terrain place, used to place poles., Marcelo Burda, 2004/05/27
- [Freeciv-Dev] Re: (PR#8624) New clima function to best handle terrain place, used to place poles., Marcelo Burda, 2004/05/27
- [Freeciv-Dev] (PR#8624) New clima function to best handle terrain place, used to place poles.,
Jason Short <=
- [Freeciv-Dev] Re: (PR#8624) New clima function to best handle terrain place, used to place poles., Marcelo Burda, 2004/05/28
- [Freeciv-Dev] Re: (PR#8624) New clima function to best handle terrain place, used to place poles., Marcelo Burda, 2004/05/29
- [Freeciv-Dev] Re: (PR#8624) New clima function to best handle terrain place, used to place poles., Jason Short, 2004/05/29
- [Freeciv-Dev] Re: (PR#8624) New clima function to best handle terrain place, used to place poles., Marcelo Burda, 2004/05/29
[Freeciv-Dev] Re: (PR#8624) New clima function to best handle terrain place, used to place poles., Marcelo Burda, 2004/05/29
|
|