[Freeciv-Dev] (PR#8624) New clima function to best handle terrain place, used to place poles.

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8624 >

> [mburda - Wed May 26 15:47:49 2004]:

> anything else?

- Why do you change the default separatepoles value?

- I think you can get rid of rand_map_pos_temperature.  Just pass the
terrain to rand_map_pos_temperature_terrain and use T_UNKNOWN for any
terrain.  (You may wish to rename the function.)

- You have:

-      if (myrand(100)>75)
+      if (myrand(100)>75 || map_temperature(x, y) <= 100 )
        map_set_terrain(x, y, T_MOUNTAINS);

why?

- Maybe I'm wrong but it seems there is very little desert.  Especially
in a torus map.  Hmm, but I think I am wrong.  It's just that desert
clumps up so if you have a "narrow" desert range you might not get any.

- You should replace 1000 with a MAX_TEMPERATURE define (or a const
variable if you prefer).  And use this value where it's needed.  In
several places you have code like if (myrand(200) > T).  Here the 200
should be MAX_TEMP/5.

- Of course the polar code is quite ugly but this is probably
unavoidable.  However the poles in topo5 are still 2 tiles wide.  Can
this be improved (should be 1 tile)?

I think that's all.

jason