[Freeciv-Dev] Re: (PR#8624) New clima function to best handle terrain place, used to place poles.

["Marcelo Burda" <mburda@xxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8624 >

Le ven 28/05/2004 à 06:16, Jason Short a écrit :
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=8624 >
> 
> > [mburda - Thu May 27 15:35:37 2004]:
> 
> > !!! that's all ?!!!
> 
> Very close.
> 
> A few very small things:
> 
> - Put MAX_TEMP in mapgen.c not mapgen.h.
> 
ok
> - Change this line:
> 
>     dist = topo_has_flag(TF_ISO) ? (2 * dist) : dist;

> to
>     dist *= topo_has_flag(TF_ISO) ? 2 : 1;
> 
if you like!
> - Change the data passed to rand_map_pos filtered from an int[3] to a
> struct {int x, y; enum tile_terrain_type t;}.  Or something like that.
> 
Yes!
> - Any macro that you define *within a function* should be #undefined
> before the end of that function.  SQSIZE and ICE_BASE_LEVEL should be
> outside of any function I think.
yes outside.
>   (P.S. Why ICE_BASE_LEVEL not just
> ICE_LEVEL?)
ICE_BASE_LEVEL is used to avoid too many land at poles   2*
ICE_BASE_LEVEL for size of poles and separate poles, in generator 5  2.5
* ICE_BASE_LEVEL is needed for really separate poles
arctic and tundra can be placed until 15%  that is realy grather than 2*
ICE_BASE_LEVEL when poles are strip (in gen1 and 5) and equat to 3 *
ICE_BASE_LEVEL when poles are islands (torus)
> 
> I think the rest is okay.  But I may find something else.  I'll look
> over it very closely before committing.
that is, i know some think to be tuned later. code from gen 2-4 asume
(not a problem) poles are number 1 and 2.
make_polar(true) shuld use some technics of gen 2-4. or we can think a
pseudo-fractal alhorithme to create a hmap for poles, or symply change
avoid edge concept!
pleas, not see too much close!
> 
> jason
-- 
 . /  .     '    ,    .      (*)   '        `     '      `    .    
  |    ,  |   `     ,     .      ,   '  Marcelo Julián Burda      .
 /  '     \     `     \@_     '      .        '      `        '    
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~