[Freeciv-Dev] Re: (PR#8627) best overview for iso-maps

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8627 >

Marcelo Burda wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=8627 >
> 
> Le mar 11/05/2004 à 06:37, Jason Short a écrit : 
> 
>><URL: http://rt.freeciv.org/Ticket/Display.html?id=8627 >
> 
> 
>>   #define NATURAL_TILE_WIDTH (topo_has_flag(TF_ISO) ? 2 : 1)
>>   #define NATURAL_TILE_HEIGHT 1
>>
>>and use NATURAL_TILE_HEIGHT in the same places you use NATURAL_TILE_WIDTH.
>>
>>(With hex tiles TF_ISO means something slightly different, so this check 
>>will change.)
> 
> ok for anything else (done)
> but i define a single var 
> OVERVIEW_TILE_SIZE in tilespec.[ch]
> and the macros
> #define OVERVIEW_TILE_WIDTH \
>     (OVERVIEW_TILE_SIZE * (topo_has_flag(TF_ISO) ? 2 : 1)) 
> #define OVERVIEW_TILE_HEIGHT OVERVIEW_TILE_SIZE
> in map.h, i think it is best,

OK but then I think this should be in either mapview_common.h or climap.h.

Everything else looks good, though I haven't studied it again closely.

jason