[Freeciv-Dev] (PR#8627) best overview for iso-maps

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8627 >

1.  I don't like the changes you make in get_mapview_corners just to
avoid recomputing the size.  A few extra *2 calculations in the client
won't hurt anything.  Can you remove these changes?

You do it in overview_update_tile too, but that's not as bad (I'd still
rather have it removed though).

2.  I can still get a crash with topology==4 in the gtk client (but not
the gtk2 client AFAIK) if I click on the right side of the overview.

#5  0x40519b3f in *__GI___assert_fail (assertion=0x0, file=0x0, line=0,
    function=0x81321d4 "overview_to_map_pos") at assert.c:83
#6  0x0807c98e in overview_to_map_pos (map_x=0xbffff29c, map_y=0xbffff2a0,
    overview_x=160, overview_y=42)
    at ../../freeciv/client/mapview_common.c:2078
#7  0x080b512b in butt_down_overviewcanvas (w=0x834fef0, ev=0x8376eb0)
    at ../../../freeciv/client/gui-gtk/mapctrl.c:372

I believe the error is in set_overview_dimensions.  You clip
OVERVIEW_TILE_SIZE pixels from the left of the overview but not from the
right.  This line:

+  overview.width = OVERVIEW_TILE_WIDTH * width + shift;

should use 2*shift.  I think.

3.  The #definition of OVERVIEW_TILE_WIDTH and OVERVIEW_TILE_HEIGHT
should go right underneath OVERVIEW_TILE_SIZE, not in climap.h.

jason