[Freeciv-Dev] Re: (PR#8627) best overview for iso-maps

["Marcelo Burda" <mburda@xxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8627 >

Le jeu 20/05/2004 à 15:17, Jason Short a écrit :
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=8627 >
> 
> Marcelo Burda wrote:
> 

> > i can solve this type of problems whit not finding the real porblem
> > returning a boolean.
> 
> I'm still pretty sure you need to use 2*shift.
> 
A 8 tiles, 1:1 ratio iso map is
AACC_
_BBDD
EEGG_
_FFHH
where _ is a balck zone

if OVZERVIEW_TILE_SIZE == 1 !
the widht of these map is 2*map.xsize + 1
if i set the whide to 2*map.xsize - 1 and then i shift all cordiantes to
the lest of one i get a map
ACC
BBD
EGG
FFH

these is i done in the code

if i make as you ask me i get a wide of 2*map.xsize - 2*1
and result map is
AC
BB
EG
FF
we lost completly the D and H tiles!

> However I can get this assertion to trigger with current CVS code and 
> topology==0.  So obviously there's something else going wrong.
> 
> Tell me again why you don't want to return a boolean?
> 
in actual code all of the used overview map are legal map coordiantes,
there is not needed at all to return a boolean, normally the return
valuel will be true all the time.

I confirm. this bug is a bug of the gtk-1 code. return boolean will hide
these problem but not resolve it!

to resolve it probably we need think in the way of the overview windows
is resize after the new map is created. but this is a point of a anoter
patch, best if resolved whit out using a return value but well using gtk
code. i am not a spetialist of these library, i can not asume these bug.

i am working in a extended patch of overview where we can link the main
windows is_isometric with a overview.is_isometric flag for maps were
!topo_has_flag(TF_ISO), for this patch we can use a return value, a
square map rotated 45° has unused space on overview code, the we will
need a return value, but not to solve this bug. 
> jason
-- 
 . /  .     '    ,    .      (*)   '        `     '      `    .    
  |    ,  |   `     ,     .      ,   '  Marcelo Julián Burda      .
 /  '     \     `     \@_     '      .        '      `        '    
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~