[Freeciv-Dev] (PR#6972) Wishlist: units lost on arctic

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=6972 >

Still some bugs:

        else if (unit_flag(punit, F_TRIREME) &&
-                trireme_loss_pct(unit_owner(punit), x1, y1, punit) > 0) {
+                unit_loss_pct(unit_owner(punit), x1, y1, punit) > 0) {
          move_cost = 2*SINGLE_MOVE+1;

I don't think you want to be checking for F_TRIREME in the first line.


In unit_loss_pct:

+  if (terrain_has_flag(map_get_terrain(x, y), TER_UNSAFE)) {
+    return loss_pct + base_unsafe_terrain_loss_pct( pplayer, punit);
   }

You need to check for air units here.  Or maybe inside
base_unsafe_terrain_loss_pct?

jason