[Freeciv-Dev] Re: (PR#6972) Wishlist: units lost on arctic

["Marcelo Burda" <mburda@xxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=6972 >

Le jeu 06/05/2004 à 20:35, Jason Short a écrit :
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=6972 >
> 
> Still some bugs:
> 
>         else if (unit_flag(punit, F_TRIREME) &&
> -                trireme_loss_pct(unit_owner(punit), x1, y1, punit) > 0) {
> +                unit_loss_pct(unit_owner(punit), x1, y1, punit) > 0) {
>           move_cost = 2*SINGLE_MOVE+1;
> 
> I don't think you want to be checking for F_TRIREME in the first line.
> 
good see!
> 
> In unit_loss_pct:
> 
> +  if (terrain_has_flag(map_get_terrain(x, y), TER_UNSAFE)) {
> +    return loss_pct + base_unsafe_terrain_loss_pct( pplayer, punit);
>    }

> You need to check for air units here.  Or maybe inside
> base_unsafe_terrain_loss_pct?
Air units are immune to Unsafe tiles unit_loss_pct was never called for
air unit. 
But you are right clear check about it is ok (inside
base_unsafe_terrain_loss_pct).
> 
> jason
about cities and air base. probably we need to make a check to forbide
make these in usafe tiles. what you think?
there are a "bug" with huts, some times this make a city on ice! i no
like it!
-- 
 . /  .     '    ,    .      (*)   '        `     '      `    .    
  |    ,  |   `     ,     .      ,   '  Marcelo Julián Burda      .
 /  '     \     `     \@_     '      .        '      `        '    
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~