[Freeciv-Dev] Re: (PR#6972) Wishlist: units lost on arctic

["Marcelo Burda" <mburda@xxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=6972 >

Le mer 05/05/2004 à 02:02, Jason Short a écrit :
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=6972 >
> 
> A few minor issues:
> 
> In is_pos_dangerous you say:
> 
> +/**********************************************************************
> +  An example of position-dangerous callback.  For all units.
> +  FIXME: it cheats.
> +***********************************************************************/
> +static bool is_pos_dangerous(int x, int y, enum known_type known,
> +                                    struct pf_parameter *param)
> 
> this needs more explanation.  How are we cheating here?  Just by 
> bypassing the unit_loss_pct function?  Or by assuming this unit is not a 
> tririeme?
> 
> Then right below you have
> 
> +  } else if (base_unsafe_terrain_loss_pct(unit_owner(punit), punit) > 0)
> +  {
> +    parameter->turn_mode = TM_WORST_TIME;
> +    parameter->is_pos_dangerous = is_pos_dangerous;
> +  } /* FIX ME triremes are safes in unsafe oceans where best naval
> +       unit are unsafe! */
>   }
> 
> I don't understand this comment.  Are you saying that if the ocean is 
> TER_UNSAFE then tririeme_is_pos_dangerous will not catch it because it 
> only checks for coasts?
Oops! no! i was fixed it myself and missed the FIXME!
my last code inlude:
 terrain_has_flag(map_get_terrain(x, y),TER_UNSAFE) 
      || (is_ocean(map_get_terrain(x, y)) && !is_safe_ocean(x, y))
in the code for triremes. this last FIXME need to be delete
> 
> I think the rest looks okay.
> 
> jason
-- 
 . /  .     '    ,    .      (*)   '        `     '      `    .    
  |    ,  |   `     ,     .      ,   '  Marcelo Julián Burda      .
 /  '     \     `     \@_     '      .        '      `        '    
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~