[Freeciv-Dev] Re: (PR#6972) Wishlist: units lost on arctic

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=6972 >

A few minor issues:

In is_pos_dangerous you say:

+/**********************************************************************
+  An example of position-dangerous callback.  For all units.
+  FIXME: it cheats.
+***********************************************************************/
+static bool is_pos_dangerous(int x, int y, enum known_type known,
+                                    struct pf_parameter *param)

this needs more explanation.  How are we cheating here?  Just by 
bypassing the unit_loss_pct function?  Or by assuming this unit is not a 
tririeme?

Then right below you have

+  } else if (base_unsafe_terrain_loss_pct(unit_owner(punit), punit) > 0)
+  {
+    parameter->turn_mode = TM_WORST_TIME;
+    parameter->is_pos_dangerous = is_pos_dangerous;
+  } /* FIX ME triremes are safes in unsafe oceans where best naval
+       unit are unsafe! */
  }

I don't understand this comment.  Are you saying that if the ocean is 
TER_UNSAFE then tririeme_is_pos_dangerous will not catch it because it 
only checks for coasts?

I think the rest looks okay.

jason