[Freeciv-Dev] Re: (PR#4701) autoattack oddities esp. with cruise missiles

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

Andy Smith wrote:
> On Tue, Jul 29, 2003 at 12:10:43AM -0700, Jason Short wrote:


> Also, some places in the code check if the player is an AI first and
> then also check ai_handicap(), but others don't.  ai_handicap()
> itself checks first if the player is AI and always returns TRUE if
> not.
> 
> So, should new uses of ai_handicap() be doing their own checking of
> pplayer->ai.control or not?  The majority do not so am I to assume
> that those which do are old/redundant?

IMO:

- pplayer->ai.control should not be checked.

- ai_handicap() should be renamed to player_has_handicap() or some such.

jason