[Freeciv-Dev] (PR#1870) borders patch feedback

["ChrisK@xxxxxxxx" <ChrisK@xxxxxxxx>]

Hello,

I've played around with CVS 01 JULY + newborders-20030630.patch

1. Coastal ocean tiles should be included in the territory IMHO.
   All city tiles (to be worked on) should also be included.
   Attached PNG shows how ugly it is now.

2. The radius calculation is not exact, which results in ugly "circles".
   Should be calculated from tile center to tile center. Guess there is a
   int() instead of a round() somewhere.

3. The "claimed by" tile info is somewhat superfluous for city tiles.

4. Suggestion (maybe for later): draw borders so that the *side* can be
   seen. Fx a semicircle instead of dashed line, with the arc to the outer
   world.

5. In the beginning when land is being discovered, there is a lot of
   flickery due to redraw of city names/description.

6. I've got a server crash when switching of fogofwar, and, later switch on
   again, on turn done:

#0  0x400b1861 in kill () from /lib/libc.so.6
#1  0x400b1665 in raise () from /lib/libc.so.6
#2  0x400b2c81 in abort () from /lib/libc.so.6
#3  0x400aba52 in Letext () from /lib/libc.so.6
#4  0x08075f1f in decrement_pending_seen (pplayer=0x81660ec, x=0, y=0) at
maphand.c:446
#5  0x08077c8f in enable_fog_of_war_player (pplayer=0x81660ec) at
maphand.c:1214
#6  0x08077cd3 in enable_fog_of_war () at maphand.c:1225
#7  0x0804defe in begin_turn () at srv_main.c:448
#8  0x0804f72c in main_loop () at srv_main.c:1417
#9  0x0804ff20 in srv_loop () at srv_main.c:1788
#10 0x0804f98b in srv_main () at srv_main.c:1574
#11 0x0804a267 in main (argc=3, argv=0xbffff5f4) at civserver.c:154
#12 0x400a07ee in __libc_start_main () from /lib/libc.so.6

   Not reproducible.

7. "Color" column in player report better named "Border"

8. Suggestion for future border effect: lift fog of war inside own borders.

HTH,
Christian

-- 
Christian Knoke     * * *      http://www.enter.de/~c.knoke/
* * * * * * * * *  Ceterum censeo Microsoft esse dividendum.