[Freeciv-Dev] Re: (PR#2748) 3 mapgen patches now through rt (sorry about that) --- 1 of 3

["kayeats@xxxxxxxxxxxxxxxxxxxxxxxxx via RT" <rt@xxxxxxxxxxxxxx>]

> A better fix than the divide by 10 hack is to take the percent from
> riverlength/total_land_tiles. Since most users won't understand the
> screwiness of riverlength, and the system should be percents everywhere
> anyway, the final tweak is to assume riverlength < 50 is already in
> percent.
>
> Conversely :-), assume it is now always in percent and for backwards
> compatibility take anything greater than 50 as a real river length.

I had initially misunderstood and I thought you were saying the current
code deals with < 50 differently than >= 50.  When I didn't see that in
the code I wondered if I had simply not looked carefully enough.

Switching cleanly to percent of land like the other terrain types seems
like the best solution all round.