[Freeciv-Dev] Re: (PR#2748) 3 mapgen patches now through rt (sorry about that) --- 1 of 3

["rwetmore@xxxxxxxxxxxx via RT" <rt@xxxxxxxxxxxxxx>]

Long overdue patch.

Two minor suggestions.

1) If you are going to account for polar, then actually put in a 
   map_polarsize static constant set to 5 and fold it into the
   normal calculations. When it becomes real all one has to do
   is change map_polarsize to map.polarsize.
   It will simplify things and make them more understandable.

2) If riverlength is under 50 it is reasonable to assume it is in 
   percent instead of absolute counts. Mapgenerators 2-4 already
   treat rivers as percent. The divide by 10 is a *gross hack*.
   and would be better represented as riverlength/grasscount or
   riverlength/landcount converted to percent if not <50.

   I like your detection of river_style to make it a real terrain
   type, but I think this needs appropriate code to make it work.

   An alternative is to convert to percent and let the code figure
   out whether to add S_RIVER to any type or make T_RIVER tiles.
   If you are not overly picky about exact counts, then the 
   assumption is that tiles will be converted in proportion to
   their existing weight, thus even the adjustment for river_style
   is not needed provided rivers are allocated last.

Cheers,
RossW
=====

At 06:30 AM 03/01/07 -0800, Guest via RT wrote:
>
>This is the simplest solution to adjust_terrain_param.  Perhaps we want
>a different solution, but certainly what is there is not good.
>
>Attachment Converted: "c:\program files\eudora\attach\betteradjusting1.dif"