[Freeciv-Dev] (PR#2437) new graphics: improvements and technology

["Jason Short via RT" <rt@xxxxxxxxxxxxxx>]

[bursig@xxxxxxxxx - Thu Dec  5 22:34:03 2002]:

> Hi
> 
> This is secound patch that should fix some issues.
> 
> > - Some trivial style issues.  Most notably pImpr should probably be
> > pimpr
> DONE

There are still some trivial spacing problems, but these can be dealt
with when the patch is applied.

> > - The capability string is set, but it is not checked.  
> > has_capability()
> > should be used for this.
> DONE

Good.  I'm still not entirely happy with a capability string of "delux"
- can anyone suggest something better?

> > - The client must not die if the graphics are not found.  This needs 
> > to
> > be tested with both supporting and non-supporting tilesets.
> Only warrning msg displayed

Yes, I was misreading the code before.

> > - Support is needed for the tileset reloading case.  I suspect this 
> > just
> > involves calling the setup functions as appropriate from within
> > tileset_reread.
> DONE

Actually, I take it back: tilespec_free_tech_gfx and
tilespec_free_impr_gfx are unnecessary (and should not exist).  The
sprites are already freed automatically when the sprite hash is emptied
in tilespec_free_tiles().

> > - We need an example tileset.
> I attach new tile theme with those gfx. ( but is only tmp solution )
> Graphics havn't been finished jet.

Cool.

jason