[Freeciv-Dev] Re: Civ 2 style happiness (PR#1436)

["Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx>]

I'm not sure you can "take specialists" from any category. The code
recomputes happiness based on luxury, improvements, wonders and units
effects, I believe. Only workers produce the basic trade. And the
various ppl_happy counts get filled in and adjusted by the computation.

  pcity->luxury_total += (pcity->ppl_elvis * 2);
  pcity->science_total += (pcity->ppl_scientist * 3);
  pcity->tax_total +=
      (pcity->ppl_taxman * 3) + get_city_tithes_bonus(pcity);

Elvis boost luxury, scientists research and taxmen income from the
trade.

So, elvis specialists will improve the happiness levels while the
others don't. Your comments seem incorrect in this regard. Do you
have an explicit example to explain what you want to change here?

Another way to do this would be to ignore the elvis contribution to
luxury and do an explicit elvis changes blort people to blah people
at a later stage.

But I don't think this is necessry or advisable.

Cheers,
RossW
=====
                                                                              
At 10:11 AM 02/05/11 -0700, Raahul Kumar wrote:
>--- Thanasis Kinias <tkinias@xxxxxxxxxxxxx> wrote:
>> scripsit Per I. Mathisen:
>> > On Mon, 6 May 2002, Raahul Kumar wrote:
>> > > The current implementation of specialists is wrong. Civ 2 has
>> > > specialists taken from content citizens. If there are no content
>> > > citizens, unhappy citizens are used instead.
>> > >
>> > > The current Freeciv implementation is very buggy, in that unhappy
>> > > citizens are considered first! This makes elvises not very useful,
>> > > as the same amount of taxmen or scientists solve your happiness
>> > > problems just as well.
>> > 
>> > Do people agree that this is a bug, and one that needs fixing now
>> > before the release?
>> 
>> I won't presume to say when it ought to be done, since I'm not the one
>> who will do the coding ;)
>
>Presume away. Since I am the one who did do the coding, I fail to see how
>a 3-5 line fix can take so much agonizing over. Bite the bullet Per.
>Commmit it.
>
>> However, regardless of how Civ2 does it, IMHO it is preferable to use
>> the content citizens first, so as to increase the differentiation among
>> specialists.  I noted this in the last game I played; it seemed strange
>> to me to take rioters off the street, put them in lab coats, and send
>> them off to cure cancer . . .
>
>That is a very funny image ;-).
>
>Aloha,
>RK.
>
>Read, every day, something no one else is reading. Think, every day,
something
>no one else is thinking. Do, every day something no one else would be silly
>enough to do. It is bad for the mind to continually be part of unanimity.
>-Christopher Morley
>
>__________________________________________________
>Do You Yahoo!?
>LAUNCH - Your Yahoo! Music Experience
>http://launch.yahoo.com