[Freeciv-Dev] Re: [Patch] Sound8

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Sun, Feb 17, 2002 at 11:41:31PM +0100, Per I. Mathisen wrote:
> On Fri, 1 Feb 2002, Raimar Falke wrote:
> > Please test and review.

> What is the conceptual difference between an e_event and an E_event ("a
> subset of normal events" as the README says)? I don't see that.

It is just for clarification. It was an ad-hoc solution. The better
one would be to convert all sound events to real events and just add
the ability to a sound to an event.

> Other than that, the changes look great. There are some excess sounds in
> stdsounds.tar.gz, I've noted. When you place wavs into cvs please be
> careful to not add any wavs that are unused.

> Here is a new version of the patch. I've been unable to find any reason
> for the delay bug that you found with the sdl plugin, Raimar, but it would
> be nice to hear if the cacheing stuff reduces this delay for you.

No it doesn't. rpm shows:
SDL_mixer-devel-1.0.5-5
SDL-1.1.8-1
SDL_mixer-1.0.5-5
SDL-devel-1.1.8-1

> CHANGES

>  - updated to current cvs
>  - reduced verbosity of logging a bit, and changed non-fatal LOG_FATALs
>    into LOG_ERRORs

Ok.

>  - changed MAX_NUMBER_PLUGINS to an enum

No. This just created extra dependencies which are unnecessary.

>  - swapped esd for sdl as preferred sound out

This has to be reverted if there aren't any reason why SDL is better
then ESD.

>  - made esd actually use the cacheing for cacheing (massively reducing
>    the number of file reads)
>  - rewrote the sdl code. now it also caches, and uses a separate music
>    channel. fixed a bug that would happen if we got too few channels
>    available
>  - civ2sounds.spec updated
>  - emptied b_generic in stdsounds.spec; it was given the same sound
>    as the end of turn bell and would not have been audible, and
>    sounds for buildings is probably not a good idea anyway...

Please use sometimes uppercase chars in your comments.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Using only the operating-system that came with your computer is just
  like only playing the demo-disc that came with your CD-player."