[Freeciv-Dev] Re: [Patch] Sound8

["Per I. Mathisen" <Per.Inge.Mathisen@xxxxxxxxxxx>]

On Mon, 18 Feb 2002, Raimar Falke wrote:
> Replace all send_audio at the server side with notify_* calls. Add
> events to do this. In handle_chat_msg add something like
>     audio_play_sound(get_sound_tag_for_event(packet->event),
>                      get_alt_sound_tag_for_event(packet->event));
> Remove audio_packet.

Ah. That discussion. Yes, the audio packet is a hack. But I still hold
that the whole notify_* concept is fundamentally flawed, and that yours
and Dirk's notes patch was a step in the right direction.

On Mon, 18 Feb 2002, Raimar Falke wrote:
> What obscure bug?

After a short while sound stopped working, although everything looked fine
from civclient's side. I've tried to reproduce the error without much
success lately, so maybe it is gone now. I just never found the few cases
of cmdline-spamming to be much of a problem, so I left the code like that
without giving it much thought. Feel free to change it (ie remove all but
the one obvious call to esd_sample_stop).

Yours,
Per

"What we anticipate seldom occurs: but what we least expect generally
happens." -- Benjamin Disraeli