[Freeciv-Dev] Re: package_dumb_city: Assertion failed (PR#1266)

[Christian Knoke <ChrisK@xxxxxxxx>]

On Mon, Feb 18, 2002 at 03:41:15PM +0100, Raimar Falke wrote:
> On Mon, Feb 18, 2002 at 05:05:10AM -0800, Christian Knoke wrote:
> > On Mon, Feb 18, 2002 at 11:43:48AM +0100, Raimar Falke wrote:
> > > On Sun, Feb 17, 2002 at 01:29:42PM -0800, Christian Knoke wrote:
> > > > On Sun, Feb 17, 2002 at 01:13:21PM -0800, Christian Knoke wrote:
> > > > > CVS ~15 FEB 2002 GTK+ Linux i386 w/ some small patches
> > > > > 
> > > > > Don't know what happened, just saved and reloaded and got 
> > > > > this after 'start':
> > > > > 
> > > > > ...
> > > > > Alaric is now hard.
> > > > > civserver: citytools.c:1308: package_dumb_city: 
> > > > > Assertion 'pcity != ((void *)0)' failed.
> > > > > Abgebrochen (core dumped)
> > > > > 
> > > > > Reproducible from savegame:
> > > > > 
> > > > > http://www.enter.de/~c.knoke/bugs/dump_city.sav.gz
> > > > > 
> > > > > Login as chris.
> > > > 
> > > > Ok, this is an ongoing game. Happens also with CVS 17 FEB.
> > > > I have two previous savegames:
> > > 
> > > > 1. Year +1060 which doesn't crash:
> > > >    http://www.enter.de/~c.knoke/bugs/dump_city_a.sav.gz
> > > > 
> > > > 2. Year +1070 which is the first one crashing:
> > > >    http://www.enter.de/~c.knoke/bugs/dump_city_b.sav.gz
> > > 
> > > What have you done between these? Especially about the city
> > > "Carncastle" which caused the error?
> > 
> > Nothing, really. I'm innocent ;-) At most I passed along that town 
> > with a trireme. No military intervention. But the trireme may have
> > sunk or got killed by a destroyer.
> 
> I'm lost. Infos so far: the savegame dump_city.sav.gz contains a
> dumb_city entry for "Carncastle" for player "chris" but "Carncastle"
> isn't anymore -> assert triggers. I suspect that this was caused by my
> change which introduces player_has_traderoute_with_city in
> server/citytools.c. However this change only triggers if there is a
> traderoute with the city ("Carncastle"). And Christian didn't build
> one. If it is an old error why was it uncovered now? Any ideas?

Here is another pair of subsequent savegames which don't crash / crash
from another game, but with the same seed and randseed. Maybe this
helps you to debug:

1. Year +0040 which doesn't crash:
   http://www.enter.de/~c.knoke/bugs/dump_city_c.sav.gz

2. Year +0060 which crashes:
   http://www.enter.de/~c.knoke/bugs/dump_city_d.sav.gz

Christian

-- 
http://www.enter.de/~c.knoke/  * * * * * * * * * * * * * * *
* * * * * * * * *  Ceterum censeo Microsoft esse dividendum.