[Freeciv-Dev] Re: [Patch] Sound8

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Mon, Feb 18, 2002 at 09:31:38PM +0100, Per I. Mathisen wrote:
> On Mon, 18 Feb 2002, Raimar Falke wrote:
> > Replace all send_audio at the server side with notify_* calls. Add
> > events to do this. In handle_chat_msg add something like
> >     audio_play_sound(get_sound_tag_for_event(packet->event),
> >                      get_alt_sound_tag_for_event(packet->event));
> > Remove audio_packet.
> 
> Ah. That discussion. Yes, the audio packet is a hack. But I still hold
> that the whole notify_* concept is fundamentally flawed, and that yours
> and Dirk's notes patch was a step in the right direction.

If nobody objects I would like to see this handled in the proper
way. I will also do the changes if you don't step forward.

> On Mon, 18 Feb 2002, Raimar Falke wrote:
> > What obscure bug?
> 
> After a short while sound stopped working, although everything looked fine
> from civclient's side. I've tried to reproduce the error without much
> success lately, so maybe it is gone now. I just never found the few cases
> of cmdline-spamming to be much of a problem, so I left the code like that
> without giving it much thought. Feel free to change it (ie remove all but
> the one obvious call to esd_sample_stop).

I'm sure that we will get questions about the "weird {ss} output". So
I'm for removing.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  This message has been ROT-13 encrypted twice for extra security.