[Freeciv-Dev] Re: [Patch] Add BOOL_VAL around ANDs

[Petr Baudis <pasky@xxxxxxxxxxx>]

Dear diary, on Sun, Feb 17, 2002 at 03:56:35AM CET, I got a letter,
where "Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx> told me, that...
> At 03:00 PM 02/02/12 +0100, Raimar Falke wrote:
> >On Tue, Feb 12, 2002 at 01:26:25PM +0000, Gregory Berkolaiko wrote:
> >>  --- Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> wrote: 
> >> > On Tue, Feb 12, 2002 at 01:37:10PM +0100, Petr Baudis wrote:
> >I'm looking for people's opinions. For direction of the patches in
> >general and errors. 
> >
> >Will 24 hours be enough?
> 
> 3 weeks to 6 months settling time is about par for most patches. For
> people with a poor track record in terms of submitted bugs and usability
> issues, the upper end is probably preferable :-).
> 
> Pick something in this range.

I think the lowest bound may ok for big patches like the sound patch, but I
certainly wouldn't be happy with this for small patches like my AI cleanups; it
would take ages to cleanup some measurable amount of AI code, keeping the
patches small and easily reviewable.

In the OSD the people are doing work voluntarily, thus they need also strong
motivation; and seeing that your patches are already getting into the main tree
is a big part of it. With such long review times it dissolves a lot..

-- 

                                Petr "Pasky" Baudis

* elinks maintainer                * IPv6 guy (XS26 co-coordinator)
* IRCnet operator                  * FreeCiv AI hacker
.
No one can feel as helpless as the owner of a sick goldfish.
.
Public PGP key && geekcode && homepage: http://pasky.ji.cz/~pasky/